Ticket #37 (closed bug: fixed)

Opened 2 months ago

Last modified 2 months ago

adc_avr.c

Reported by: anonymous Assigned to:
Priority: minor Milestone:
Component: Drivers Version:
Keywords: AVR ADC Cc:

Description

Check following lines - double use of MUX3

INLINE void adc_hw_select_ch(uint8_t ch) {

/* Set to 0 all mux registers */ ADMUX &= ~(BV(MUX3) | BV(MUX3) | BV(MUX2) | BV(MUX1) | BV(MUX0));

/* Select channel, only first 8 channel modes are supported for now */ ADMUX |= (ch & 0x07);

}

correct?:

INLINE void adc_hw_select_ch(uint8_t ch) {

/* Set to 0 all mux registers */ ADMUX &= ~(BV(MUX4) | BV(MUX3) | BV(MUX2) | BV(MUX1) | BV(MUX0));

/* Select channel, only first 8 channel modes are supported for now */ ADMUX |= (ch & 0x07);

}

Attachments

Change History

11/18/08 11:47:59 changed by batt

  • status changed from new to closed.
  • resolution set to fixed.

Yes, you are right, there is a pasto! Fixed in svn revision r1935.

Add/Change #37 (adc_avr.c)




Change Properties
Action